fix "formatting on save" potentially running on outdated document state #2336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reported on Discord where with both "code actions on save" and "formatting on save" enabled, the formatting would be done on an outdated document state if code actions have triggered an edit.
Reproducible with a go document like:
and following project settings:
That resulted in broken edit where part of the added
import
would be missing.The
FormattingTask
did trigger_purge_changes_async()
on start but since the tasks ran in one continuous flow on the async thread, we didn't get to handle ST'son_text_changed
notification in between tasks.Fix by starting next task from
set_timeout_async
to allow pending events to trigger.