-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various refactorings #2366
Various refactorings #2366
Conversation
Oh wow, I didn't know that you used the TreeView somewhere else. That is cool. The reason I initially put And I could do a PR to update the imports in LSP-jdtls with the next LSP release. I guess that would be easier than to leave behind some aliases to those constants in |
Yeah, new paths are nicer. Only that we should make sure to update those and do a synced release. |
Created sublimelsp/LSP-volar#212 |
Looks like this needs to be rebased to be be able to use "reabse and merge" strategy. |
The "index" argument name is already used by various built-in commands (see Default/Main.sublime-menu), so let's follow that example.
It is possible to avoid the import loop by using the TYPE_CHECKING constant from the typing module to avoid the import of TreeViewSheet at runtime, because it is only used for the type comment.
db3a1b5
to
e982afb
Compare
These are a bunch of minor refactorings that I wanted to do. Most of it just moves some code to other places where it makes more sense, but there are no functional changes. See the individual commits for details.
Everything touched by this PR should just be internal functions and constants, so I believe it should be safe to do. At some time the public API for LSP-* packages in
LSP/plugin/__init__.py
should probably be revised and extended, because various packages already import utility functions directly fromLSP/plugin/core/views.py
.To be released together with: