Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some mypy type issues in stubs #2374

Merged
merged 6 commits into from
Dec 13, 2023
Merged

Fix some mypy type issues in stubs #2374

merged 6 commits into from
Dec 13, 2023

Conversation

rchl
Copy link
Member

@rchl rchl commented Dec 12, 2023

  • Check stubs using mypy. Noticed some type issues when checking lsp_utils.
  • Ignore reportIncompatibleMethodOverride pyright warning which is reported in the new pyright version because it has introduced a new, stricter typeCheckingMode "standard" that is enabled by default.

rchl
rchl commented Dec 12, 2023
View reviewed changes
stubs/sublime.pyi Outdated Show resolved Hide resolved
jwortmann
jwortmann reviewed Dec 13, 2023
View reviewed changes
stubs/sublime.pyi Outdated Show resolved Hide resolved
jwortmann
jwortmann reviewed Dec 13, 2023
View reviewed changes
stubs/sublime.pyi Outdated Show resolved Hide resolved
jwortmann
jwortmann reviewed Dec 13, 2023
View reviewed changes
tox.ini Show resolved Hide resolved
jwortmann
jwortmann reviewed Dec 13, 2023
View reviewed changes
stubs/sublime.pyi Outdated Show resolved Hide resolved
@rchl @jwortmann
Update stubs/sublime.pyi
640d1f4 
Co-authored-by: jwortmann <[email protected]>
@rchl rchl changed the title Improve type stubs Fix some mypy type issues in stubs Dec 13, 2023
@rchl rchl merged commit ae332f9 into main Dec 13, 2023
4 checks passed
@rchl rchl deleted the fix/stub-types branch December 13, 2023 11:36
rchl added a commit that referenced this pull request Dec 13, 2023
@rchl
Merge branch 'main' into fix/sync-on-open
22deb1e 
* main:
  add NO_UNDO flags to all regions (#2370)
  Fix some mypy type issues in stubs (#2374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwortmann jwortmann jwortmann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rchl @jwortmann