refactor task running on save #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwortmann
reviewed
Jan 2, 2024
plugin/save_command.py
Outdated
Comment on lines
75
to
77
| for Task in self._tasks: | ||
| if Task.is_applicable(self._text_command.view): | ||
| self._pending_tasks.append(Task(self._text_command, self._on_task_completed_async)) |
There was a problem hiding this comment.
It wasn't changed in this PR, but the uppercase Task is a bit inconsistent with the lines 113-115 in this file, where it is lowercase. I don't know what the convention is (or if a convention exists for it), but I would say it should either be lowercase here or uppercase in lines 113-115.
In __init__ the tasks parameter is also lowercase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the code that runs tasks on saving to handle cancellation properly when running
lsp_savecommand twice in a row, in a sync fashion.Previously the queued
_run_next_task_asynccallback from the first invocation still triggered after the first invocation was canceled, triggering an exception.Now the tasks running logic is encapsulated into its own class, making cancelling easier and more robust.