Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing check for multiline highlighting #2392

Closed
wants to merge 1 commit into from
+2 −0
Closed

fix missing check for multiline highlighting #2392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions plugin/documents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,6 +820,8 @@ def render_highlights_on_main_thread() -> None:
if not regions:
continue
kind, multiline = tup
if multiline and not userprefs().show_multiline_document_highlights:
continue
Comment on lines +823 to +824
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember exactly how all of this works but shouldn't the existing same check above prevent those from being added to kind2regions in the first place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, yes, thanks, it seems I had an unrelated multiline preference set and wasn't working

key = self._highlights_key(kind, multiline)
flags = flags_multi if multiline else flags_single
self.view.add_regions(key, regions, scope=DOCUMENT_HIGHLIGHT_KIND_SCOPES[kind], flags=flags)
Expand Down