Remove unnecessary argument from lsp_symbol_rename command #2413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that this command has two arguments
position
andpoint
, with one of them being unnecessary. Currentlyposition
is just an internal argument used to pass it to itself when the command is re-triggered after prepareRename response. It seems thatposition
existed beforepoint
was added (to LspTextCommand), but now we can usepoint
for that instead. The logic should be completely unaffected by this change, and the line withlocation = ...
(105) can be simplified becauseget_position
also preferspoint
if given.