Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary argument from lsp_symbol_rename command #2413

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

jwortmann
Copy link
Member

I saw that this command has two arguments position and point, with one of them being unnecessary. Currently position is just an internal argument used to pass it to itself when the command is re-triggered after prepareRename response. It seems that position existed before point was added (to LspTextCommand), but now we can use point for that instead. The logic should be completely unaffected by this change, and the line with location = ... (105) can be simplified because get_position also prefers point if given.

@rwols rwols merged commit ab33520 into sublimelsp:main Feb 5, 2024
8 checks passed
@jwortmann jwortmann deleted the rename-position branch February 5, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants