Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ignore this PR] Ci/maybe fix Ubuntu test #2442

Closed
wants to merge 7 commits into from

Conversation

predragnikolic
Copy link
Member

No description provided.

jwortmann and others added 7 commits March 26, 2024 21:46
This fixes for example the Pyright warning
LSP-pyright: Received change text document command for closed file <URI>
when a file is saved and closed immediately after changes were applied.
view.change_count() returns 0 if the view isn't valid anymore (closed),
so we can simply use short-circuit evaluation for this and don't need
the is_valid() API call.
@predragnikolic
Copy link
Member Author

predragnikolic commented Apr 10, 2024

The CI failed because of Linting, but the CI works on Ubuntu cc @jwortmann
https://github.com/sublimelsp/LSP/actions/runs/8634239586/job/23669197170?pr=2442

I do not know if this is some issue with UnitTesting,
but at least we don't have to turn off tests like in 4dd2e91

Tests somehow affect other tests...
I do not know why, nor I want to spend my time looking and pinpointing the issue :D

CI tests behave differently than tests run locally
Somehow I thought that the solution that DeathAxe wrote in a different PR will also work here, but it didn't...

So I finally found a way to avoid it -> b3c6cbb

@predragnikolic predragnikolic deleted the ci/maybe-fix-ubuntu-test branch April 10, 2024 16:05
@jwortmann
Copy link
Member

Nice, I will update the PR. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants