-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use variable annotations instead of type comments on Python 3.8 #2450
Conversation
This reverts commit c70cd57.
* main: Cut 1.29.0 Fix usage of sublime.score_selector (sublimelsp#2427) docs: add info about typst-lsp commands (sublimelsp#2424)
This commit adopts `unittesting.ViewTestCase` to run view related test cases. ViewTestCase ... 1. provides `view` and `window` members pointing to a dedicated view, being created for testing. 2. ensures not to close empty windows, which was probably the most likely reason for unittests failing before on MacOS.
…if things go wrong
LSP v2.0.0 will be released tomorrow I do plan to merge your py38 PRs at the beginning of next week. Tuesday. I plan to release python 3.8 tomorrow, After that I plan to continue with merging the new PR's. |
Test fail on Windows :)
|
https://peps.python.org/pep-0526/
I used this regex to replace them:
But I did a little bit of fine tuning by hand afterwards, because the regex didn't catch multi-line expressions, and a few type comments were not valid syntax.
I can change the target branch if we want to wait for the Python 3.8 release first.