-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LSP.plugin.core.typing with py38 #2456
Fix LSP.plugin.core.typing with py38 #2456
Conversation
110bbf3
to
51c719c
Compare
Signed-off-by: Jack Cherng <[email protected]>
Hello, I tested this, and it looks like the Some LSP-jdtls, LSP-julia, LSP-volar import NotRequired from LSP.plugin.core.typing. This PR breaks them: |
9378474
to
dfbde05
Compare
@predragnikolic Wondering whether |
f6304e6
to
1856443
Compare
Signed-off-by: Jack Cherng <[email protected]>
It works. Ideally LSP-* plugins can now import types from And instead of List, Dict, we can use |
Signed-off-by: Jack Cherng <[email protected]>
Yeah. That's what I encountered. When using |
bb19295
to
ac2ee2b
Compare
Signed-off-by: Jack Cherng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works.
* Import __future__ annotations This commit... 1. adds `from __future__ import annotations` to each relevant module in order to enable language level type annotation support. 2. as a result most quotation marks can be removed from type annotations. * Remove quotes from return types * Avoid conflict with PR #2456 --------- Co-authored-by: Предраг Николић <[email protected]>
Thanks! |
Since we are now in py38, we don't need most of type polyfills.
# noqa: F401
is to suppressimport but no used
linter warnings.