Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more use of typing_extensions module #2460

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

deathaxe
Copy link
Contributor

This commit replaces various homegrown type definitions by imports from typing_extensions module.

This commit replaces various homegrown type definitions by imports
from typing_extensions module.
The `typing_extensions` module is a compatibility layer between python versions.
Required types can always be imported from it, even if available via `typing`
natively.
Copy link
Member

@predragnikolic predragnikolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@predragnikolic predragnikolic merged commit a3867f4 into sublimelsp:main Apr 23, 2024
8 checks passed
@deathaxe deathaxe deleted the feat/use-typing_extension branch April 23, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants