Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More small code style improvements #2557

Merged
merged 5 commits into from
Nov 16, 2024

Conversation

jwortmann
Copy link
Member

... continuing from #2537.

There should be no functional change.

@rchl
Copy link
Member

rchl commented Nov 16, 2024

(rewrote history to merge linting fixing into respective commits)

@predragnikolic predragnikolic merged commit 4fea4c5 into sublimelsp:main Nov 16, 2024
8 checks passed
@jwortmann jwortmann deleted the code-style-2 branch November 16, 2024 15:09
@jwortmann
Copy link
Member Author

jwortmann commented Nov 16, 2024

(rewrote history to merge linting fixing into respective commits)

But then you squashed it into a single commit :D

Ah sorry it was @predragnikolic who "destroyed" the commit history. But nevermind, I would probably also have squashed the commits. I think we can leave it like that, these changes were really small and I don't think anybody will want to look up these individual changes in the future.

@rchl
Copy link
Member

rchl commented Nov 16, 2024

Yeah, my intention was to merge them as separate commits but will keep as is then.

@rchl
Copy link
Member

rchl commented Nov 16, 2024

BTW. You can have your branches directly in this repo if you'd prefer that.

@jwortmann
Copy link
Member Author

To be honest I kind of prefer using a personal remote repo. There are already various stale branches in this repo. But I guess it would make it easier for you to quickly checkout my branches or add changes if I would push directly to this repo... I'll think about it.

@predragnikolic
Copy link
Member

predragnikolic commented Nov 16, 2024

Choosing "squash and merge" was a bad decision on my part. Sorry for the inconvenience and effort that @rchl did to group commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants