Update url.py to fit WSL path that starts with "\\wsl.local"

[95833]

No description provided.

[jwortmann]

Suggested change

	if path[0] == '\\':
	if path.startswith('\\'):

[jwortmann]

Could you add a test in the tests/test_url.py file with an example, i.e. some URL that is not handled correctly at the moment but would be fixed with this pull request?

I see there is already a test for a WSL URL at

LSP/tests/test_url.py

Lines 39 to 42 in c64ac00

	def test_wsl_path(self):
	scheme, path = parse_uri('file://wsl%24/Ubuntu-20.04/File.php')
	self.assertEqual(scheme, "file")
	self.assertEqual(path, R'\\wsl$\Ubuntu-20.04\File.php')

but you could add another one after that which would be handled by the change in this pull request.

[95833]

Can you teach me how to use tests?

[jwortmann]

Basically look at the code that I linked above. You can just copy the 3 lines and change the URL to parse (with something that currently doesn't work) and also the expected outcome. self.assertEqual(A, B) means that A must evaluate to the same as B.

[95833]

I don't know how to run this test.

[jwortmann]

The CI check on GitHub will run it after you pushed another commit.

[95833]

Can't I run it locally? It's a bit annoying to have to push to GitHub every time I test the code.

[jwortmann]

To manually run tests locally you need to install the UnitTesting package from package control. See https://github.com/sublimelsp/LSP/blob/main/CONTRIBUTING.md#testing

I haven't done this though, but usually you know what the expected outcome should be, so it should be fine to just push new commits until it works. The commits will be squashed into a single one when the PR gets merged anyway.

[95833]

Okay

[95833]

To provide support for WSL paths, I think it would be better to update the underlying packages related to path handling rather than changing the program logic; the issue seems to have become somewhat complex. I think the best solution would be to create a branch that supports WSL paths. So this PR will be closed.