Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable workaround for on_post_move_async listener not triggering #2582

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jwortmann
Copy link
Member

It was fixed upstream, so we can get rid of accessing the undocumented (private) sublime_plugin.view_event_listeners dict on current builds.

@jwortmann
Copy link
Member Author

I wonder if the previous (current) code was even correct in case there are multiple simultaneous sessions for the view, because of the return statement at line

LSP/boot.py

Line 240 in c64ac00

return

(which was even active before rewriting that line in my PR #1927 and) which presumably would cause to miss re-registering of additional sessions.

@rchl
Copy link
Member

rchl commented Dec 20, 2024

I wonder if the previous (current) code was even correct in case there are multiple simultaneous sessions for the view, because of the return statement at line

LSP/boot.py

Line 240 in c64ac00

return

(which was even active before rewriting that line in my PR #1927 and) which presumably would cause to miss re-registering of additional sessions.

But DocumentSyncListener is per view, not per session, so calling listener.on_post_move_window_async once should be enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants