Ensure all string enum values are comparable to strings #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a workaround for a problem described at sublimelsp/LSP#2446 (comment)
Currently it would not work on Python 3.8 to import directly from
enum
, because most of the enums with string values are just regularEnum
instead ofStrEnum
. This means we can't compare values to the strings from a server response. But if they areStrEnum
, they could be compared directly (in theory, because StrEnum is not part of Python 3.8 - but this means that the enums inherit from our fake StrEnum class, instead of to the real Enum class from the enum module).I think then it should work, together with another small change I have in mind.