-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add string Literal types #16
Conversation
I think that the String Literal types might be useful instead of StrEnum. |
Now, Each |
I don't really understand how this is supposed to be used in the code. if params['kind'] == CodeActionKind.QuickFix: and it gives autocompletions for the members when typing the dot. Where would we use the Literal types? |
I see. But this would only help against typos, and ideally we always want to use the enum constants in the code, instead of writing the string literal directly. And various of the enums allow additional custom values defined by the server; for example the SemanticTokenTypes, or the FoldingRangeKind. So this would even be wrong to restrict the allowed values for those enums. So I guess it was the right choice to close this for now :-) |
No description provided.