Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LSP-robloxlua #2

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add LSP-robloxlua #2

wants to merge 11 commits into from

Conversation

alihsaas
Copy link

No description provided.

@rchl rchl force-pushed the main branch 4 times, most recently from ab94059 to 5145b52 Compare September 23, 2020 09:03
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: LSP-robloxluau
Results help

Packages added:
  - LSP-robloxluau

Processing package "LSP-robloxluau"
  - WARNING: '.no-sublime-package' is defined. Please verify that it is *really* necessary
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 17, Column: 11

@rwols
Copy link
Member

rwols commented Sep 30, 2020

I think we should wait with merging this. I have concocted a method to put a built zipped package in a draft release. This is much cleaner than committing all of the binary artifacts in the git repository.

@rwols
Copy link
Member

rwols commented Sep 30, 2020

A blocker for my method is that Package Control doesn't handle redirects (wbond/package_control#1502). The URL to the zip files are redirected by GitHub (with a HTTP 302 response) to some amazon S3 storage somewhere on this planet.

To see how it can work, see https://github.com/sublimelsp/lsp-lua/
It is entirely based on "github workflows".

  1. There is a github workflow that I trigger manually from the "Actions" tab on the repo: https://github.com/sublimelsp/LSP-lua/blob/main/.github/workflows/build-draft-release.yml this creates a draft release and uploads three zip files, ready to be unzipped by Package Control
  2. I browse to the draft release and then click on "publish release"
  3. This triggers another github workflow: https://github.com/sublimelsp/LSP-lua/blob/main/.github/workflows/notify-repository-on-published-release.yml this workflow makes a HTTP REST api call to this github repo
  4. this github repo has a workflow that awaits a rest call and then automatically creates a pull request from it: https://github.com/sublimelsp/repository/blob/main/.github/workflows/on-new-release.yml

Writing this out, I am wondering whether a third party can also do the HTTP REST call and trigger a pull request automatically...

@alihsaas
Copy link
Author

Alright, thanks, I will close this PR then and generate a new one once the LSP is ready.

@alihsaas alihsaas closed this Sep 30, 2020
@rwols
Copy link
Member

rwols commented Sep 30, 2020

Let’s keep this open otherwise I’ll forget about it

@rwols rwols reopened this Sep 30, 2020
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: LSP-robloxluau
Results help

Packages added:
  - LSP-robloxluau

Processing package "LSP-robloxluau"
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 25, Column: 11
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: Roblox-Luau.sublime-syntax

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: LSP-robloxluau
Results help

Packages added:
  - LSP-robloxluau

Processing package "LSP-robloxluau"
  - ERROR: fetching package HTTP error 302 downloading https://github.com/alihsaas/LSP-robloxluau/releases/download/v0.0.1/LSP-robloxluau_windows-x64.zip.

@rwols
Copy link
Member

rwols commented Oct 2, 2020

I remember there were XML files in the package previously, but now I don't see them in the zip files. Is this intended?

@alihsaas
Copy link
Author

alihsaas commented Oct 2, 2020

I remember there were XML files in the package previously, but now I don't see them in the zip files. Is this intended?

Yah, you are right. I forgot to include the rbx/ directory in the make file

web-flow and others added 3 commits October 2, 2020 11:38
This release contains the latest version of the RobloxLuau language server.
Sublime-Text-Version-Range: >=4070
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: LSP-robloxluau
Results help

Packages added:
  - LSP-robloxluau

Processing package "LSP-robloxluau"
  - ERROR: fetching package HTTP error 302 downloading https://github.com/alihsaas/LSP-robloxluau/releases/download/v0.0.2/LSP-robloxluau_windows-x64.zip.

@rwols
Copy link
Member

rwols commented May 21, 2021

I wonder if this isn't better solved by a few "interface" files, in the same sense of Python interface files (.pyi). For example there's also "love2d" Lua and there's "World of Warcraft" Lua, and so on.

Relevant discussions:

Copy link

@STReviewBot STReviewBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: LSP-robloxluau
Results help

Packages added:
  - LSP-robloxluau

Processing package "LSP-robloxluau"
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 25, Column: 11
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: Roblox-Luau.sublime-syntax

@alihsaas
Copy link
Author

I wonder if this isn't better solved by a few "interface" files, in the same sense of Python interface files (.pyi). For example there's also "love2d" Lua and there's "World of Warcraft" Lua, and so on.

Relevant discussions:

* [Automatically adapt to the project environment sumneko/lua-language-server#409](https://github.com/sumneko/lua-language-server/issues/409)

* [Meta files sumneko/lua-language-server#389](https://github.com/sumneko/lua-language-server/discussions/389)

Not sure will this work considering the LSP needs to resolve special syntax which Roblox adds, like the compound assignment and type syntax, these files are just for function/object definitions right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants