-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LSP-robloxlua #2
base: main
Are you sure you want to change the base?
Conversation
ab94059
to
5145b52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: WARNING
Repo link: LSP-robloxluau
Results help
Packages added:
- LSP-robloxluau
Processing package "LSP-robloxluau"
- WARNING: '.no-sublime-package' is defined. Please verify that it is *really* necessary
- WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
- File: plugin.py
- Line: 17, Column: 11
I think we should wait with merging this. I have concocted a method to put a built zipped package in a draft release. This is much cleaner than committing all of the binary artifacts in the git repository. |
A blocker for my method is that Package Control doesn't handle redirects (wbond/package_control#1502). The URL to the zip files are redirected by GitHub (with a HTTP 302 response) to some amazon S3 storage somewhere on this planet. To see how it can work, see https://github.com/sublimelsp/lsp-lua/
Writing this out, I am wondering whether a third party can also do the HTTP REST call and trigger a pull request automatically... |
Alright, thanks, I will close this PR then and generate a new one once the LSP is ready. |
Let’s keep this open otherwise I’ll forget about it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: WARNING
Repo link: LSP-robloxluau
Results help
Packages added:
- LSP-robloxluau
Processing package "LSP-robloxluau"
- WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
- File: plugin.py
- Line: 25, Column: 11
- WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
- File: Roblox-Luau.sublime-syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: ERROR
Repo link: LSP-robloxluau
Results help
Packages added:
- LSP-robloxluau
Processing package "LSP-robloxluau"
- ERROR: fetching package HTTP error 302 downloading https://github.com/alihsaas/LSP-robloxluau/releases/download/v0.0.1/LSP-robloxluau_windows-x64.zip.
I remember there were XML files in the package previously, but now I don't see them in the zip files. Is this intended? |
Yah, you are right. I forgot to include the rbx/ directory in the make file |
This release contains the latest version of the RobloxLuau language server. Sublime-Text-Version-Range: >=4070
Update LSP-robloxluau
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: ERROR
Repo link: LSP-robloxluau
Results help
Packages added:
- LSP-robloxluau
Processing package "LSP-robloxluau"
- ERROR: fetching package HTTP error 302 downloading https://github.com/alihsaas/LSP-robloxluau/releases/download/v0.0.2/LSP-robloxluau_windows-x64.zip.
I wonder if this isn't better solved by a few "interface" files, in the same sense of Python interface files (.pyi). For example there's also "love2d" Lua and there's "World of Warcraft" Lua, and so on. Relevant discussions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: WARNING
Repo link: LSP-robloxluau
Results help
Packages added:
- LSP-robloxluau
Processing package "LSP-robloxluau"
- WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
- File: plugin.py
- Line: 25, Column: 11
- WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
- File: Roblox-Luau.sublime-syntax
Not sure will this work considering the LSP needs to resolve special syntax which Roblox adds, like the compound assignment and type syntax, these files are just for function/object definitions right? |
No description provided.