Add LSP-webhare #44
Add LSP-webhare #44
Conversation
|
Was support for gitlab fixed in Package Control already? If so I will have to update the review bot. |
|
It looks like support for gitlab has been merged into Package Control in wbond/package_control#1481. |
|
Yes, it was but then someone actually tried it and it didn't actually work - wbond/packagecontrol.io#138 |
|
Ah, I see. I guess I'll leave this PR open until that issue gets resolved? |
|
@krisbreuker @rchl I believe this PR Gitlab PR will resolve this |
|
As the package control PR has been merged and the package mentioned in the comment above is now available in package control, it seems to me that the Sublime LSP repository should now also be able to accept GitLab packages. |
There was a problem hiding this comment.
Automated testing result: ERROR
Repo link: LSP-webhare
Results help
Packages added:
- LSP-webhare
Processing package "LSP-webhare"
- ERROR: Invalid "details" value "https://gitlab.com/webhare/lsp/LSP-webhare" for one of the packages.
|
Unfortunately your repo is still not supported as it's within a "Group" in which case the URL has different structure. Both the repository tests (https://github.com/wbond/package_control_channel/blob/a01883ea86a73ce8a61de32e3b86229accd15199/tests/test.py#L185-L202) and especially the Package Control (https://github.com/wbond/package_control/blob/master/package_control/clients/gitlab_client.py) don't support that currently. |
|
Please report this at the PC repo if you haven't already. |
|
Going to look into this. As I thought we took groups into consideration |
|
Update, I am working to fix Gitlab once again :) |
No description provided.