Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate lsp_utils releases for ST3/4 #88

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Separate lsp_utils releases for ST3/4 #88

merged 1 commit into from
Oct 30, 2023

Conversation

deathaxe
Copy link
Contributor

lsp_utils 2.x is last compatible ST3 release

As of 3.0.0 ST4070+ is requied.

This PR makes required changes for Package control to pick up correct versions.

Copy link

@STReviewBot STReviewBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

@rchl
Copy link
Member

rchl commented Oct 30, 2023

This didn't work the last time I've tried but I guess that's because of the missing v in the tag name?

@deathaxe
Copy link
Contributor Author

Probably. Leading v is only automatically removed if tags: true is given. Otherwise prefix must completely match.

Just verified it with my internal v4 channel, which grapped it correctly.

@rchl rchl merged commit dae8967 into sublimelsp:main Oct 30, 2023
1 check passed
@rchl
Copy link
Member

rchl commented Oct 30, 2023

Thanks

@rchl
Copy link
Member

rchl commented Oct 30, 2023

BTW. The last time I've tried it also broke the ST4 case. So we have to be on a lookout for this possibly breaking again.

@deathaxe
Copy link
Contributor Author

Yeah. PC3x drops a whole package as "broken", if signle release branches don't match anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants