Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate LSP-json release for ST3 #91

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Separate LSP-json release for ST3 #91

merged 1 commit into from
Dec 2, 2023

Conversation

rchl
Copy link
Member

@rchl rchl commented Dec 1, 2023

No description provided.

@rchl
Copy link
Member Author

rchl commented Dec 1, 2023

@deathaxe various places had if 'includes' in self.j: check before your changes. It crashes now with those removed.

@rchl
Copy link
Member Author

rchl commented Dec 2, 2023

I suppose the more high level question, why is includes considered a required key? It shouldn't be in this repo.

@deathaxe
Copy link
Contributor

deathaxe commented Dec 2, 2023

That's an (unexpected/unwanted) side effect from syncing with tests from package_control_channel repo, which includes are a core part of the structure for.

The whole code base is pretty specific for testing the default channel in general.

see first commit after 1.0.0: packagecontrol/st-schema-reviewer-action@e74fd97

@deathaxe
Copy link
Contributor

deathaxe commented Dec 2, 2023

Should be fixed.

Copy link

@STReviewBot STReviewBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - LSP-json

@rchl rchl merged commit 0bfb8d8 into main Dec 2, 2023
1 check passed
@rchl rchl deleted the fix/st3-json branch December 2, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants