Added some instanceconfigs and added person registration applications #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jgrim Please make a deep check here as i changed a lot. |
Pdzly
commented
Nov 27, 2023
src/main/resources/db/migration/V20231006__Create_foreign_key_references.sql
Outdated
Show resolved
Hide resolved
…tion' into ferature/49-registration-application
jgrim
reviewed
Nov 28, 2023
src/main/resources/db/migration/V20231003__Create_initial_entity_tables.sql
Show resolved
Hide resolved
jgrim
requested changes
Nov 28, 2023
src/main/resources/db/migration/V20231003__Create_initial_entity_tables.sql
Outdated
Show resolved
Hide resolved
src/main/resources/db/migration/V20231003__Create_initial_entity_tables.sql
Outdated
Show resolved
Hide resolved
src/main/resources/db/migration/V20231006__Create_foreign_key_references.sql
Outdated
Show resolved
Hide resolved
src/main/resources/db/migration/V20231003__Create_initial_entity_tables.sql
Outdated
Show resolved
Hide resolved
Comment on lines
+614
to
+615
| `registration_mode` ENUM ('Closed', 'RequireApplication', 'Open') NOT NULL DEFAULT 'Closed', | ||
| `registration_question` TEXT NULL, |
There was a problem hiding this comment.
I'm thinking on this more, just a handful of columns add so much more code and complexity. Not sure how I feel about it given that we plan to store config data when possible for nonlocal instances.
There was a problem hiding this comment.
We can save it as a json in one column XD
But it was the first instance after that, for adding another one is just 3-4 lines of code.
...ava/com/sublinks/sublinksapi/api/lemmy/v3/common/controllers/AbstractLemmyApiController.java
Show resolved
Hide resolved
src/main/java/com/sublinks/sublinksapi/instance/dto/Instance.java
Outdated
Show resolved
Hide resolved
Merged
jgrim
approved these changes
Dec 3, 2023
Pdzly
pushed a commit
that referenced
this pull request
May 24, 2024
…tion-application Added some instanceconfigs and added person registration applications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #49