Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional "precache" flag #276

Closed
wants to merge 10 commits into from
Closed

Add optional "precache" flag #276

wants to merge 10 commits into from

Conversation

bartekpacia
Copy link
Collaborator

resolves #256 (what a nice round number!)

@bartekpacia bartekpacia changed the title Add Add optional "precache" flag Mar 2, 2024
@bartekpacia bartekpacia marked this pull request as draft March 2, 2024 04:18
@bartekpacia bartekpacia marked this pull request as ready for review March 24, 2024 18:14
@bartekpacia
Copy link
Collaborator Author

bartekpacia commented Mar 24, 2024

Ping @subosito. I think this implementation is good enough (it surely is for my use case :) ). flutter precache is smart enough to only download artifacts for platforms which can be targeted from the current one - i.e. it won't download ios and macos artifacts on a Linux machine. More details: flutter/flutter#144656

@bartekpacia
Copy link
Collaborator Author

I just realized that this PR doesn't make sense. The archives that this action downloads already contain all the relevant artifacts:

For example take a look at contents of these directories:

These Linux archive already contain:

  • bin/cache/artifacts/material_fonts
  • bin/cache/artifacts/engine/android-arm64 (with -profile and -release variants)
    and so on

The macOS archive also contains macOS- and iOS-specific stuff like bin/cache/artifacts/ios-deploy/ios-deploy.

@bartekpacia bartekpacia closed this by deleting the head repository Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to automatically run flutter precache
1 participant