Starknet init

[stwiname]

No description provided.

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9418406	Triggered	Generic Password	2ccbc5b	.github/workflows/benchmark.yml	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[github-actions]

Coverage report

Caution

Test run failed

St.❔	Category	Percentage	Covered / Total
🔴	Statements	40.97%	1866/4555
🟡	Branches	65.51%	188/287
🔴	Functions	49.74%	94/189
🔴	Lines	40.97%	1866/4555

Test suite run failed

Failed tests: 1/39. Failed suites: 1/9.

  ● Codegen spec › validate Abi.json path field

    expect(received).rejects.toThrow(expected)

    Expected pattern: /Asset: "zkLend" not found in project/
    Received message: "Error: Asset zkLend, file ./abis/xxx.json does not exist"

          127 |     const filePath = path.join(projectPath, value.file);
          128 |     if (!fs.existsSync(filePath)) {
        > 129 |       throw new Error(`Error: Asset ${name}, file ${value.file} does not exist`);
              |             ^
          130 |     }
          131 |     // We use actual abi file name instead on name provided in assets
          132 |     // This is aligning with files in './ethers-contracts'

      at addAsset (packages/common-starknet/src/codegen/codegen-controller.ts:129:13)
      at prepareSortedAssets (packages/common-starknet/src/codegen/codegen-controller.ts:141:7)
      at generateAbis (packages/common-starknet/src/codegen/codegen-controller.ts:234:24)
      at Object.<anonymous> (packages/common-starknet/src/codegen/codegen-controller.spec.ts:40:19)
      at Object.toThrow (node_modules/expect/build/index.js:210:22)
      at Object.<anonymous> (packages/common-starknet/src/codegen/codegen-controller.spec.ts:41:15)

Report generated by 🧪jest coverage report action from 8f7f20e

[stwiname]

It should be possible to use typechain here too https://github.com/dethcrypto/TypeChain/tree/master/packages/target-starknet

[jiqiang90]

I still found some types issue, will follow up starknet-io/types-js#31