Refx/warnings #53
Merged
Refx/warnings #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudara
reviewed
Jan 11, 2024
| @@ -41,7 +41,10 @@ namespace melatonin::blur | |||
| vImage_Buffer src = { copyData.getLinePointer (0), h, w, (size_t) data.lineStride }; | |||
|
|
|||
| vImage_Buffer dst = { data.getLinePointer (0), h, w, (size_t) data.lineStride }; | |||
|
|
|||
| JUCE_BEGIN_IGNORE_WARNINGS_GCC_LIKE ("-Wunguarded-availability-new") | |||
There was a problem hiding this comment.
This relates to #13 (comment) — curious why they are fired as warnings at all, I'm assuming it's because the macOS target (like CMAKE_OSX_DEPLOYMENT_TARGET) is lower than these functions and the compiler just has no way to know that we've guarded them?
|
Thanks! I'm going to do another pass on the tests, getting close to warning free everywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up a few warnings