Skip to content
This repository has been archived by the owner on Sep 29, 2022. It is now read-only.

Escape suggestion ids #88

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Escape suggestion ids #88

wants to merge 2 commits into from

Conversation

alaninnovates
Copy link
Contributor

@alaninnovates alaninnovates commented Mar 20, 2022 •
edited
Loading

Remove all non alphanumeric characters from commands that take suggestion id as an argument.

Closes #83

acollierr17
acollierr17 reviewed Apr 3, 2022
View reviewed changes
src/utils/functions.js Outdated Show resolved Hide resolved
acollierr17
acollierr17 suggested changes Apr 3, 2022
View reviewed changes
Copy link
Member

@acollierr17 acollierr17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, just want you to take a look at the JSDOC comment for the escapeSuggestionId function.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acollierr17 acollierr17 acollierr17 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

For commands that pass in the suggestion ID, escape non-letter/number characters
2 participants
@alaninnovates @acollierr17