-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove async_trait crate due to increased MSRV #234
Conversation
I wonder if there's a better way to do this without having to repeat the method definitions for every async trait method. I'm not particularly fond of that, but it seems that you cannot add a |
I don't know much about it, but I understand that JsValue is not- So I'm wondering if we could do something similar by using the Since there should be no need to have both a #[cfg_attr(not(target_arch = “wasm32”), trait_variant::make(Send))] |
5d6c33a
to
4a9a4de
Compare
Force-pushed to resync the branch with #233. |
2bcdbbb
to
4d45c41
Compare
Force-pushed again to re-do the commit for the wasm implementation, and again to format it. @sugyan your suggestion worked wonderfully, |
It was nice to have a cleaner code! As for |
Ok! I'll proceed with turning this into a proper PR when #233 is merged then. |
4d45c41
to
0858a2c
Compare
This PR is due to #233 and should only be merged after that one is merged