Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: agent rework #243

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

[WIP] feat: agent rework #243

wants to merge 18 commits into from

Conversation

sugyan
Copy link
Owner

@sugyan sugyan commented Nov 8, 2024

No description provided.

@sugyan sugyan force-pushed the feature/agent-rework branch from 2561fcc to 6734492 Compare November 8, 2024 13:55
@avdb13
Copy link
Contributor

avdb13 commented Nov 24, 2024

What's missing here exactly?

@avdb13
Copy link
Contributor

avdb13 commented Nov 24, 2024

Caught up with your changes: #242

@sugyan
Copy link
Owner Author

sugyan commented Nov 25, 2024

My current thoughts are.

  • Implementation around OAuthSession session management
    • Can we write some tests?
  • Agent rework
    • There should still be methods available in a common interface
    • How to integrate into bsky-sdk?
  • After all, agent rework and OAuth session should be separate features, and pull-request should be able to be separated. Which should be done first?

@avdb13
Copy link
Contributor

avdb13 commented Nov 28, 2024

Which should be done first?

Seems like the last two PRs dealt with the latter, correct me if I'm wrong and something is missing.

@sugyan
Copy link
Owner Author

sugyan commented Nov 28, 2024

@avdb13 I think it would be better to do the agent rework first, but it is a bit tedious and involves some processing specific to atproto, and I think it would be better for me to do it.

As for the OAuthSession part, only the SessionManager trait needs to be added to the api, but other than that, I think your branch is generally implemented. I think it would be possible to merge them if you could split those parts and send them in a separate pull-request.

@avdb13
Copy link
Contributor

avdb13 commented Dec 18, 2024

I'm gonna wait for this PR to be completed as sebadob/rauthy#644 requires the Agent to be available for us to fetch the email associated with the user's ATProto account, prompting for one if not present.

@avdb13
Copy link
Contributor

avdb13 commented Dec 24, 2024

it is a bit tedious and involves some processing specific to atproto, and I think it would be better for me to do it.

@sugyan it's been a month since the last commit, I really wanna take on implementing the remaining changes so could you please share instructions? Sorry for my impatience in advance.

@sugyan
Copy link
Owner Author

sugyan commented Dec 24, 2024

@avdb13 I am very sorry for the halt in progress.
Since the beginning of December, I have been busy with my personal life and have very little time to concentrate on writing code.... I will try to find time during the year-end and New Year holidays to work on the project, so I would appreciate it if you could wait a little longer.

@avdb13
Copy link
Contributor

avdb13 commented Dec 24, 2024

@avdb13 I am very sorry for the halt in progress.
Since the beginning of December, I have been busy with my personal life and have very little time to concentrate on writing code.... I will try to find time during the year-end and New Year holidays to work on the project, so I would appreciate it if you could wait a little longer.

I knew something was wrong but I was hesitant to ask about it as this project is driven by voluntary contribution after all. Best of luck and merry christmas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants