[HOLD- changes to be made] Turning A-Z and numerical sort buttons blue instead of red #2808
+25
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have set this up as an alternative starting point: projectblacklight/blacklight#3492 |
|
The upstream Blacklight work has been backported into release 8.x here: projectblacklight/blacklight#3499 |
hudajkhan
changed the title
|
When the upstream work is available in the ?next? 8.x release, we should be able to pull this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2797 .
What this PR does:
The button styling for the A-Z and numerical sort is included within Blacklight's FacetFieldPaginationComponent. This PR overrides that component and then includes our own styling.
Note: It seems it would be better to split out the sort portion of Blacklight's own component so we could just override that, or if we could split out just the styling part. Thoughts welcome.