Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIcmd (or Screen) mode #92

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

VIcmd (or Screen) mode #92

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 30, 2016

Issue: If using FrankenWM remotely, I could not use ALT4 key.

Solution: I start a new command using CTRL-A, then optional numbers for how many times to repeat the command, and then the command itself: For Example:
CTRL-A 5 SHIFT-Return starts 5 Terminals

Press ESC or CTRL-A again to cancel the command.

Because 0-9 do not translate well over RDP, too, I changed these to F1-F10

Poweruser feature: If Person wants to hide the command window, set SHOW_COMMANDWIN to False. (Do this on your own risk, because there will be no indication, FrankenWM waits for input)

TODO: The command window itself looks pretty bad ugly.
It needs some more gfx care for sure.

@ghost
Copy link
Author

ghost commented Mar 30, 2016

Reason was because former version ended up so big, earlier this morning I merged the fullscreen-regression fix and git imported the entire history with it. (I'm learning something new about git every day :)

@sulami
Copy link
Owner

sulami commented Mar 31, 2016

First of all:

/snip

@ghost
Copy link
Author

ghost commented Mar 31, 2016

I am deeply sorry for that bad experience.

To me, it smells like XK_F0 (and propably (XK_F1-XK_F9) is not defined.

Here what happens on my side:
[user@flatant FrankenWM]$ git co master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
[user@flatant FrankenWM]$ git co VIcmds
Switched to branch 'VIcmds'
Your branch is up-to-date with 'origin/VIcmds'.
[user@flatant FrankenWM]$ make clean
cleaning
removed 'frankenwm'
removed 'frankenwm.o'
[user@flatant FrankenWM]$ make
frankenwm build options:
CFLAGS = -std=c99 -pedantic -Wall -Wextra -I. -I/usr/local/include -I/usr/X11R6/include -g
LDFLAGS = -lc -lX11 -lxcb-util -lxcb-icccm -lxcb-keysyms -lxcb-ewmh -lxcb -g
CC = cc
CC frankenwm.c
CC -o frankenwm
[user@flatant FrankenWM]$

@ghost
Copy link
Author

ghost commented Mar 31, 2016

could you try this option in your Makefile?
-Wfatal-errors

Description:
-Wfatal-errors
This option causes the compiler to abort compilation on the first
error occurred rather than trying to keep going and printing fur‐
ther error messages.

Thanks.

@sulami
Copy link
Owner

sulami commented Mar 31, 2016

I found the issue, you accidentely defined F0, which screws up everything else
after that, no big deal. I fixed that and published a new upstream branch here
on GH to work on. togglecmdmode is still unused, and before this can make it
into master, there also needs to be documentation.

On Thu, Mar 31, 2016 at 08:09:19AM -0700, Ulrich Kaufmann wrote:

I am deeply sorry for that bad experience.

To me, it smells like XK_F0 (and propably (XK_F1-XK_F9) is not defined.

Here what happens on my side:
[user@flatant FrankenWM]$ git co master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
[user@flatant FrankenWM]$ git co VIcmds
Switched to branch 'VIcmds'
Your branch is up-to-date with 'origin/VIcmds'.
[user@flatant FrankenWM]$ make clean
cleaning
removed 'frankenwm'
removed 'frankenwm.o'
[user@flatant FrankenWM]$ make
frankenwm build options:
CFLAGS = -std=c99 -pedantic -Wall -Wextra -I. -I/usr/local/include -I/usr/X11R6/include -g
LDFLAGS = -lc -lX11 -lxcb-util -lxcb-icccm -lxcb-keysyms -lxcb-ewmh -lxcb -g
CC = cc
CC frankenwm.c
CC -o frankenwm
[user@flatant FrankenWM]$


You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#92 (comment)

Robin Schroer

@ghost
Copy link
Author

ghost commented Apr 1, 2016

First thing this morning, I wanted to send you my own config.h, then saw your new comment pointing in the right direction.
Fixed the F10 binding in config.def.h file.
and added the much needed Ctrl-A binding to the config.def.h file.
EDIT: and updated the man-file.

@sulami
Copy link
Owner

sulami commented Apr 2, 2016

Okay, I merged your latest additions and tweaked the new manpage section a bit.
One thing I am still thinking about is enabling this by default and binding it
to C-a, which might surprise some people that do not know of this functionality.
I think I like C-a as a default shortcut, even though it clashes with screen
(and many tmux configs).

I also have to test this somewhat thoroughly myself before actually pushing it
to master, so in this time, maybe we can come up with some way to not destroy
screen users' workflow by default. I have been thinking about just adding a
#define to disable this by default without burying it in the shortcuts section
of the config, but I am open for suggestions on how to handle this best.

@ghost
Copy link
Author

ghost commented Apr 4, 2016

Users who need tihs feature either use screen (ctrl-a) or tmux (ctrl-b), so they can bind this feature to the unused ctrl-binding (ctrl-a in my case, because I use tmux)

This feature should not clash with any existing command-binding, because all it does is replacing mod4 with ctrl-a and then use the same command-binding table. Only extra thing is the optional number on how many times to repeat the command.

Feel free to test it "auf Herz und Nieren" :)

THERE is one thing I am unsure about: can we use the normal CLEANMASK or should we use a new mask NOMOD4MASK. It works with this mask, but I do not know if we really need it.

Thanks a bunch.

I'm also open to any suggestions about a niecer looking command-window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant