Updating single sign on documentation #797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…setting the domain via configuration.
|
@tic984 Thx for the pull request but this is more a bug then a documentation part. This will be fixed in: sulu/sulu#7421. Still thank you for your pull request. |
|
Thank you still for your pr. added you as a co authored of sulu/sulu#7421 which should fix the issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating single sign on documentation with information on explicitly setting the domain via configuration.
What's in this PR?
This PR introduces an amendment to the documentation regarding Single Sign-On (SSO) configuration in the Sulu project.
Why?
The existing documentation lacked clarity regarding the configuration option for specifying the domain. This PR addresses this issue by providing explicit instructions on how to configure the domain key, which is essential for seamless integration with Single Sign-On providers. Additionally, it includes a note highlighting the importance of specifying the domain key to avoid potential normalization issues.
I enountered the issue while following the sample in the documentation and provided a domain with "-" in it.