Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: upgrading node version for admin build #802

Open
wants to merge 6 commits into
base: 2.6
Choose a base branch
from
Open

update: upgrading node version for admin build #802

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
642db14
Simplify global blocks example to ref (#798)
alexander-schranz May 7, 2024
13881e7
Merge branch '2.6' of github.com:sulu/sulu-docs into 2.x
alexander-schranz May 13, 2024
aaac7ab
Merge branch '2.6' of github.com:sulu/sulu-docs into 2.x
alexander-schranz May 21, 2024
f94fb66
Fix refernce bundle paragraph spaces (#801)
alexander-schranz May 21, 2024
f751ceb
update: upgrading node version for admin build
lubomirfiala May 22, 2024
cb123d0
Merge branch 'sulu:2.x' into patch-1
lubomirfiala May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cookbook/build-admin-frontend.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Solution 2: Build manually with docker

.. code-block:: bash

docker run --rm --interactive --tty --volume ${PWD}:/var/project node:14.16.0 /bin/bash
docker run --rm --interactive --tty --volume ${PWD}:/var/project node:20-alpine3.18 /bin/sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not add -alpine as they might sometimes make problems so I would keep with the default image and the /bin/bash


# for completion: using another node version is possible by adjusting the tag of the node image
# docker run --rm --interactive --tty --volume ${PWD}:/var/project node:12.21.0 /bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also change this line e.g. using 18.19.0

Expand Down