Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling enhanced Ruff linting #246

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Abinash-bit
Copy link
Contributor

@Abinash-bit Abinash-bit commented Nov 13, 2024

PR Description

  1. Enabled Extended Ruff Linting : Updated the use_extended_ruff_linting variable to "y" via cruft update to apply the extended linting rules across the repository.
  2. Code Formatting : Locally formatted the code using tox -e codestyle to adhere to the community's formatting standards.
  3. Applied Ruff Formatting Fixes : Used ruff check --unsafe-fixes to automatically correct a large portion of the linting and formatting issues with minimal disruption.
  4. Manually addressed any remaining linting and formatting issues that were not automatically fixed by ruff
    Screenshot 2024-11-13 171503
    Screenshot 2024-11-13 171557
    Screenshot 2024-11-13 171623
    .

This fixes #241 .

@nabobalis nabobalis added the No Changelog Entry Needed Skip any changelog checks. label Nov 13, 2024
@nabobalis nabobalis merged commit f8c3e09 into sunpy:main Nov 13, 2024
22 of 23 checks passed
@nabobalis
Copy link
Contributor

Thanks @Abinash-bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Entry Needed Skip any changelog checks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable enhanced Ruff linting
2 participants