Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a github actions doc build #25

Closed
wants to merge 3 commits into from
Closed

Add a github actions doc build #25

wants to merge 3 commits into from

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Jun 25, 2021

Still to do:

  • Replace pyvista example with sunkit-pyvista example
  • Have examples render output
  • Push the rendered docs to a github pages

Url is https://sunpy.github.io/sunkit-pyvista/

@dstansby dstansby force-pushed the doc-build branch 2 times, most recently from 6595bbd to 566de94 Compare June 25, 2021 20:34
@nabobalis nabobalis marked this pull request as draft June 26, 2021 08:36
@nabobalis nabobalis force-pushed the doc-build branch 20 times, most recently from 59c60e4 to ea76a33 Compare July 5, 2021 16:01
Comment on lines +5 to +6
pull_request:
branches: [main]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed before merge.

@nabobalis nabobalis force-pushed the doc-build branch 4 times, most recently from 66c5551 to dde7cb0 Compare July 9, 2021 11:14
@@ -169,7 +170,7 @@ def plot_map(self, m, clip_interval: u.percent = None, **kwargs):
"specified as two numbers.")
else:
clim = [0, 1]
self.plotter.add_mesh(map_mesh, cmap=cmap, clim=clim, **kwargs)
self.plotter.add_mesh(map_mesh, cmap="RdYlBu", clim=clim, **kwargs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be reverted.

@dstansby
Copy link
Member Author

Right, I've narrowed the issue down to ipygany not showing meshes that have some nan vertices in them. This is common for images of the Sun, as all the off-disc coordinates are set to nan.

@dstansby
Copy link
Member Author

As a bit more of a paper trail, here's the relevant issue (or possibly it's a feature request): jupyter-widgets-contrib/ipygany#63

@dstansby dstansby closed this Aug 2, 2021
@nabobalis nabobalis deleted the doc-build branch August 3, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants