Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds BackgroundPlotter class which can be used for animations #57

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jeffreypaul15
Copy link
Collaborator

@jeffreypaul15 jeffreypaul15 commented Jul 27, 2021

From #32, moved the Background Plotting to another class.

  • Tests
  • Examples

@jeffreypaul15
Copy link
Collaborator Author

Would it make more sense to have the Mapsequence Animator class in the same file as the background plotter?

@nabobalis
Copy link
Contributor

Would it make more sense to have the Mapsequence Animator class in the same file as the background plotter?

Assuming it won't be too long, they can be in the same file. if the plan is to have multiple animator classes, we could split them out after.

@jeffreypaul15
Copy link
Collaborator Author

Would it make more sense to have the Mapsequence Animator class in the same file as the background plotter?

Assuming it won't be too long, they can be in the same file. if the plan is to have multiple animator classes, we could split them out after.

Alright, I'll make that change then

@nabobalis
Copy link
Contributor

nabobalis commented Jul 30, 2021

Do we also want a figure test?

 from sunkit_pyvista import SunpyPlotter
E   ImportError: cannot import name 'SunpyPlotter' from partially initialized module 'sunkit_pyvista' (most likely due to a circular import) (/home/vsts/work/1/s/.tox/py39/lib/python3.9/site-packages/sunkit_pyvista/__init__.py)

I think you might need to reorder some imports.

@jeffreypaul15
Copy link
Collaborator Author

Do we also want a figure test?

 from sunkit_pyvista import SunpyPlotter
E   ImportError: cannot import name 'SunpyPlotter' from partially initialized module 'sunkit_pyvista' (most likely due to a circular import) (/home/vsts/work/1/s/.tox/py39/lib/python3.9/site-packages/sunkit_pyvista/__init__.py)

I think you might need to reorder some imports.

Yeah I need to push these changes, I'm still stuck at trying to figure out why the button widget is failing

@dstansby dstansby added this to the 0.2 milestone Aug 13, 2021
@nabobalis nabobalis marked this pull request as draft June 20, 2022 23:20
@nabobalis nabobalis modified the milestones: 0.2, 0.4.0 Jun 18, 2024
@nabobalis
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants