Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fly refactoring; fixes; extra LSN shipping coverage #800

Merged
merged 69 commits into from
Dec 15, 2023

Conversation

pcnc
Copy link
Member

@pcnc pcnc commented Nov 20, 2023

  • Refactors LSN checkpoint creation and handling
    • Introduces handler that regularly ships the checkpoint file - used as a backup for cases such as volume corruption
      • Currently at 10 minute intervals, if the latest LSN has updated in the meantime
    • Ships the checkpoint after supervisord exits, as a backup to when signal handling goes awry
  • Some fixes around perms and order of operations when unpacking the init payload

pcnc and others added 20 commits November 17, 2023 15:56
* chore: bump admin-api and admin-mgr

* chore: init read-replica.conf
* and ensure it's accounted for everywhere

* chore: bump version

* chore: remove rc versioning

* chore: use admin-api v0.54.0 instead

* chore: include read-replica.conf from start
…796)

* chore: ensure fail2ban stays disabled when FAIL2BAN_DISABLED is set

* chore: update docker aio entrypoint with extra validation on env vars check
@pcnc pcnc requested a review from a team as a code owner November 20, 2023 19:17
docker/all-in-one/entrypoint.sh Show resolved Hide resolved
docker/all-in-one/entrypoint.sh Outdated Show resolved Hide resolved
docker/all-in-one/shutdown_event_listener.py Outdated Show resolved Hide resolved
docker/all-in-one/shutdown_event_listener.py Outdated Show resolved Hide resolved
docker/all-in-one/shutdown_event_listener.py Outdated Show resolved Hide resolved
docker/all-in-one/shutdown_event_listener.py Outdated Show resolved Hide resolved
docker/all-in-one/shutdown_event_listener.py Outdated Show resolved Hide resolved
@darora
Copy link
Contributor

darora commented Nov 21, 2023

Testinfra AIO tests were passing in the past I think?

@bmpandrade
Copy link
Contributor

Still failing test-infra-aio with:

E           requests.exceptions.ConnectionError: HTTPConnectionPool(host='localhost', port=8000): Max retries exceeded with url: /rest/v1/buckets (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0xffffbc858f70>: Failed to establish a new connection: [Errno 111] Connection refused'))

Looks like services are taking longer to start and it fails.

@pcnc , will look into the test suite and see if there is a hold we can do until services are up and running, or if the service itself failed to start.

Copy link
Contributor

@bmpandrade bmpandrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it looks good, but I got a bit confused about the db-only as referred on the other code comments.

I thought, that only on special cases db-only was used, and the fly extensions was not one of them. Wouldn't this make us update the worker too, when deploying to Fly to treat it as a db-only, to ensure that LSN checkpoints were being properly uploaded?

.github/workflows/dockerhub-release.yml Outdated Show resolved Hide resolved
docker/all-in-one/Dockerfile Outdated Show resolved Hide resolved
docker/all-in-one/entrypoint.sh Outdated Show resolved Hide resolved
@pcnc pcnc requested a review from a team as a code owner December 14, 2023 17:08
@pcnc pcnc merged commit e149265 into develop Dec 15, 2023
7 of 8 checks passed
@pcnc pcnc deleted the pcnc/fly-fixes-redux branch December 15, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.