-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fly refactoring; fixes; extra LSN shipping coverage #800
Conversation
pcnc
commented
Nov 20, 2023
- Refactors LSN checkpoint creation and handling
- Introduces handler that regularly ships the checkpoint file - used as a backup for cases such as volume corruption
- Currently at 10 minute intervals, if the latest LSN has updated in the meantime
- Ships the checkpoint after supervisord exits, as a backup to when signal handling goes awry
- Introduces handler that regularly ships the checkpoint file - used as a backup for cases such as volume corruption
- Some fixes around perms and order of operations when unpacking the init payload
* chore: bump admin-api and admin-mgr * chore: init read-replica.conf * and ensure it's accounted for everywhere * chore: bump version * chore: remove rc versioning * chore: use admin-api v0.54.0 instead * chore: include read-replica.conf from start
…796) * chore: ensure fail2ban stays disabled when FAIL2BAN_DISABLED is set * chore: update docker aio entrypoint with extra validation on env vars check
Testinfra AIO tests were passing in the past I think? |
Still failing test-infra-aio with:
Looks like services are taking longer to start and it fails. @pcnc , will look into the test suite and see if there is a hold we can do until services are up and running, or if the service itself failed to start. |
28882ca
to
564a4a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general it looks good, but I got a bit confused about the db-only
as referred on the other code comments.
I thought, that only on special cases db-only
was used, and the fly extensions was not one of them. Wouldn't this make us update the worker too, when deploying to Fly to treat it as a db-only
, to ensure that LSN checkpoints were being properly uploaded?
Co-authored-by: Bruno Andrade <[email protected]>
Co-authored-by: Bruno Andrade <[email protected]>
fd0237c
to
d51d282
Compare
d51d282
to
6d460a7
Compare
…vices:envoy` to adminapi sudoers `supervisorctl status` is used as part of the supervisord commands equivalent to `systemctl try-restart`.
It's fine to leave it `true` while toggling `autostart`.
a4164f7
to
3220a48
Compare