perf(envoy): only log when status code >=400, switch from file to stdout access logger #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick checks using the simple-update k6 benchmark from https://github.com/thebengeu/simple-supabase-benchmarks on t4g.nano, with SCALE=30 and 100 VUs over 3 minutes: - Kong: 442 rps, req duration med=129ms p(90)=410ms p(95)=668ms - Envoy log all: 613 rps, req duration med=155ms p(90)=207ms p(95)=250ms - Envoy log errors: 761 rps, req duration med=126ms, p(90)=154ms, p(95)=179ms So on this benchmark, this change results in ~24% more rps than Envoy logging all requests, ~72% more rps than Kong. Kong is also configured to only log errors, `proxy_access_log = off` here: https://github.com/supabase/postgres/blob/a3938dc906010ce197c240d0052b3eda9ecac339/docker/all-in-one/etc/kong/kong.conf#L12.
darora
approved these changes
Dec 9, 2023
thebengeu
force-pushed
the
beng/envoy-access-log
branch
from
4e79cf8 to
7e580fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick checks using the simple-update k6 benchmark from https://github.com/thebengeu/simple-supabase-benchmarks on t4g.nano, with SCALE=30 and 100 VUs over 3 minutes:
So on this benchmark, this change results in ~24% more rps than Envoy logging all requests, ~72% more rps than Kong. Kong is also configured to only log errors,
proxy_access_log = offhere:postgres/docker/all-in-one/etc/kong/kong.conf
Line 12 in a3938dc