fix(types): inner join type on nullable relationships #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avallete
commented
Mar 28, 2025
Comment on lines
+94
to
+97
| hotel: { | ||
| id: number | ||
| name: string | null | ||
| } |
There was a problem hiding this comment.
note
Since this come from an !inner join it should not be null as it's filtered at the join level.
soedirgo
approved these changes
Mar 29, 2025
|
🎉 This PR is included in version 1.19.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank's to MRE example repo setup here: https://github.com/masda70/supabase-non-null-inner-join/tree/working
Fixes the type for
!innerjoin that are typed as nullable but shouldn't.Fixes: supabase/supabase-js#1368