fix: Reduce postgres user grants #1159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces the permissions given to the postgres user to reduce error prone operations from users when interacting with the schema 'realtime'
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
chasers
approved these changes
Sep 19, 2024
1 similar comment
soedirgo
reviewed
Sep 20, 2024
lib/realtime/tenants/repo/migrations/20240919140541_reduce_grants_postgres_user.ex
Outdated
Show resolved
Hide resolved
lib/realtime/tenants/repo/migrations/20240919140541_reduce_grants_postgres_user.ex
Show resolved
Hide resolved
lib/realtime/tenants/repo/migrations/20240919140541_reduce_grants_postgres_user.ex
Outdated
Show resolved
Hide resolved
…nts_postgres_user.ex Co-authored-by: Bobbie Soedirgo <[email protected]>
…nts_postgres_user.ex Co-authored-by: Bobbie Soedirgo <[email protected]>
soedirgo
reviewed
Sep 24, 2024
lib/realtime/tenants/repo/migrations/20240919140541_reduce_grants_postgres_user.ex
Outdated
Show resolved
Hide resolved
…nts_postgres_user.ex Co-authored-by: Bobbie Soedirgo <[email protected]>
soedirgo
approved these changes
Sep 24, 2024
filipecabaco
commented
Sep 24, 2024
| execute("revoke supabase_realtime_admin from postgres") | ||
| execute("alter default privileges for role supabase_admin in schema realtime revoke all on tables from postgres") | ||
| execute("alter default privileges for role supabase_admin in schema realtime revoke all on functions from postgres") | ||
| execute("alter default privileges for role supabase_admin in schema realtime revoke all on sequences from postgres") |
There was a problem hiding this comment.
this actually breaks our tests and implementations as supabase_admin is the user we use to connect to tenant database and we still need them 😭
so I will need to remove this 3 execute @soedirgo
There was a problem hiding this comment.
Hmm how does it break? It shouldn't affect existing tables/functions
There was a problem hiding this comment.
running required migrations fails:
18:14:41.532 project=dev_tenant external_id=dev_tenant [error] MigrationsFailedToRun: %Postgrex.Error{
message: nil,
postgres: %{
code: :undefined_object,
line: "5101",
message: "role \"supabase_admin\" does not exist",
file: "acl.c",
unknown: "ERROR",
severity: "ERROR",
pg_code: "42704",
routine: "get_role_oid"
},
connection_id: 156,
query: nil
}
There was a problem hiding this comment.
Oh we granted the default privileges here 😭 then yeah we need to move these out of Realtime tenant migrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Reduces the permissions given to the postgres user to reduce error prone operations from users when interacting with the schema 'realtime'