Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adhere to github flavoured markdown syntax #695

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Conversation

tinvaan
Copy link
Contributor

@tinvaan tinvaan commented Feb 20, 2024

What kind of change does this PR introduce?

Minor docs update - fixes several linter errors/warnings for markdown files and conforms to Github flavoured markdown syntax.

Changes are auto-generated using mdformat's github flavoured markdown plugin and also included as a pre-commit hook.

Closes #698

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Documentation

PR Summary: This pull request focuses on updating the project's documentation to adhere to Github flavored markdown syntax. It includes changes to the README.md and CODE_OF_CONDUCT.md files, among others, to improve readability and consistency across markdown files. The changes involve formatting adjustments, such as modifying header levels and updating links to use markdown syntax instead of HTML. Additionally, the PR introduces a pre-commit hook using mdformat with a plugin for Github flavored markdown to ensure future contributions maintain these standards.

Decision: Comment

📝 Type: 'Documentation' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
  • Big diff: the diff is too large to approve with confidence.

General suggestions:

  • Ensure that all placeholders like '[INSERT EMAIL ADDRESS]' in documentation are replaced with actual, relevant information to avoid confusion and ensure clarity.
  • Consider reviewing all documentation changes to ensure they not only adhere to markdown syntax but also maintain the intended meaning and readability.
  • It might be beneficial to include a brief section or note in the CONTRIBUTING.md about the introduction of the mdformat pre-commit hook, guiding contributors on how to set up their environment to comply with these formatting standards.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@@ -56,7 +55,7 @@ a project may be further defined and clarified by project maintainers.
## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported by contacting the project team at [INSERT EMAIL ADDRESS]. All
reported by contacting the project team at \[INSERT EMAIL ADDRESS\]. All
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (llm): The placeholder '[INSERT EMAIL ADDRESS]' should be replaced with an actual contact email for reporting unacceptable behavior. This is crucial for enforcing the code of conduct.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.97%. Comparing base (a3707e7) to head (5434df7).

❗ Current head 5434df7 differs from pull request most recent head 5a7d412. Consider uploading reports for the commit 5a7d412 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #695   +/-   ##
=======================================
  Coverage   43.97%   43.97%           
=======================================
  Files          13       13           
  Lines         332      332           
=======================================
  Hits          146      146           
  Misses        186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@J0
Copy link
Contributor

J0 commented Feb 27, 2024

Hey,

Thanks for the PR! Do you mind resolving the conflicts? I think this change should be fine. Thanks for the contribution! 🙏

@tinvaan
Copy link
Contributor Author

tinvaan commented Feb 28, 2024

@J0 done 👍🏼 Thanks for looking into this ❤️

Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J0
Copy link
Contributor

J0 commented Feb 29, 2024

Really sorry @tinvaan, could you run the pre-commit hook on the codebase again? Think the CHANGELOG.md resolution I made doesn't conform to linter requirements. Feel free to merge once the tests pass

@tinvaan
Copy link
Contributor Author

tinvaan commented Feb 29, 2024

@J0 no probs, I just rebased and force-pushed to the branch after running the mformat tool on the CHANGELOG & regnerating the poetry.lock lockfile.

I don't see the option to merge though. Can you help? I'll raise subsequent changesets for #697 & #698 against this base.

@J0 J0 merged commit 954d243 into supabase:main Feb 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize markdown file syntax
2 participants