fix: Add private topic to Realtime (#442)

* fix: Add private topic to Realtime * rename struct field * fix tests * remove public access control --------- Co-authored-by: Guilherme Souza <[email protected]>
supabase · Jul 4, 2024 · a491b29 · a491b29
1 parent 8a80aae
commit a491b29
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 3 deletions.
diff --git a/Sources/Realtime/V2/RealtimeChannelV2.swift b/Sources/Realtime/V2/RealtimeChannelV2.swift
@@ -12,6 +12,7 @@ import Helpers
 public struct RealtimeChannelConfig: Sendable {
   public var broadcast: BroadcastJoinConfig
   public var presence: PresenceJoinConfig
+  public var isPrivate: Bool
 }
 
 struct Socket: Sendable {
@@ -111,7 +112,8 @@ public final class RealtimeChannelV2: Sendable {
     let joinConfig = RealtimeJoinConfig(
       broadcast: config.broadcast,
       presence: config.presence,
-      postgresChanges: mutableState.clientChanges
+      postgresChanges: mutableState.clientChanges,
+      isPrivate: config.isPrivate
     )
 
     let payload = RealtimeJoinPayload(

diff --git a/Sources/Realtime/V2/RealtimeClientV2.swift b/Sources/Realtime/V2/RealtimeClientV2.swift
@@ -249,7 +249,8 @@ public final class RealtimeClientV2: Sendable {
   ) -> RealtimeChannelV2 {
     var config = RealtimeChannelConfig(
       broadcast: BroadcastJoinConfig(acknowledgeBroadcasts: false, receiveOwnBroadcasts: false),
-      presence: PresenceJoinConfig(key: "")
+      presence: PresenceJoinConfig(key: ""),
+      isPrivate: false
     )
     options(&config)
 

diff --git a/Sources/Realtime/V2/RealtimeJoinConfig.swift b/Sources/Realtime/V2/RealtimeJoinConfig.swift
@@ -21,10 +21,12 @@ struct RealtimeJoinConfig: Codable, Hashable {
   var broadcast: BroadcastJoinConfig = .init()
   var presence: PresenceJoinConfig = .init()
   var postgresChanges: [PostgresJoinConfig] = []
+  var isPrivate: Bool = false
 
   enum CodingKeys: String, CodingKey {
     case broadcast
     case presence
+    case isPrivate = "private"
     case postgresChanges = "postgres_changes"
   }
 }

diff --git a/Tests/RealtimeTests/RealtimeTests.swift b/Tests/RealtimeTests/RealtimeTests.swift
@@ -257,6 +257,7 @@ extension RealtimeMessageV2 {
             ["schema": "public", "table": "messages", "event": "DELETE"],
           ],
           "presence": ["key": ""],
+          "private": false,
         ],
       ]
     )

diff --git a/Tests/RealtimeTests/_PushTests.swift b/Tests/RealtimeTests/_PushTests.swift
@@ -38,7 +38,8 @@ final class _PushTests: XCTestCase {
       topic: "realtime:users",
       config: RealtimeChannelConfig(
         broadcast: .init(acknowledgeBroadcasts: false),
-        presence: .init()
+        presence: .init(),
+        isPrivate: false
       ),
       socket: Socket(client: socket),
       logger: nil