fix: mark :db_termination as shutdown
#475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauleth
force-pushed
the
fix/mark-db_termination-as-shutdown
branch
from
c35e472
to
6ed0001
Compare
abc3
approved these changes
Nov 11, 2024
abc3
requested changes
Nov 11, 2024
|
@abc3 everything should work as expected there, as it only changes behaviour in the supervisor. Exit message is still sent and should be handled as is. |
hauleth
force-pushed
the
fix/mark-db_termination-as-shutdown
branch
from
6ed0001
to
7a18346
Compare
That will reduce amount of error logs related to unexpected process shutdown (as `db_termination` is rather expected shutdown).
hauleth
force-pushed
the
fix/mark-db_termination-as-shutdown
branch
from
7a18346
to
b988af7
Compare
abc3
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That will reduce amount of error logs related to unexpected process shutdown (as
db_terminationis rather expected shutdown).