Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unneeded Plugs #484

Merged
merged 1 commit into from
Nov 15, 2024
Merged

chore: remove unneeded Plugs #484

merged 1 commit into from
Nov 15, 2024

Conversation

hauleth
Copy link
Contributor

@hauleth hauleth commented Nov 14, 2024

These plugs weren't used at all, as we do not serve any static assets nor we
need live reload for anything (as we do not have any form of web UI).

These plugs weren't used at all, as we do not serve any static assets nor we
need live reload for anything (as we do not have any form of web UI).
@hauleth hauleth requested a review from a team as a code owner November 14, 2024 17:42
@hauleth hauleth merged commit 43dd1fc into v2 Nov 15, 2024
5 checks passed
@hauleth hauleth deleted the chore/remove-unneeded-plugs branch November 15, 2024 11:06
@hauleth
Copy link
Contributor Author

hauleth commented Nov 15, 2024

I think that in future we should move phoenix_live_view to development dependencies as well, as we do not use it in production. This would reduce potential attack surface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants