Check if we're updating the correct transaction by checking the Trans…

…actionReference to the TransactionId as sent by icepay
superbrave · Mar 4, 2020 · 2515ea0 · 2515ea0
1 parent e6cb614
commit 2515ea0
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/Message/TransactionStatusRequest.php b/src/Message/TransactionStatusRequest.php
@@ -77,6 +77,12 @@ private function getTransactionStatusFromPostBack(): ?TransactionStatusResponse
 
         $this->setContractProfileId($contentAsStdObj->ContractProfileId);
 
+        // Make sure we're updating the correct payment by reference, and not all of them.
+        // Note: $contentAsArray['Reference'] is not the same as TransactionReference.
+        if ($this->getTransactionReference() !== trim($contentAsArray['TransactionId'])) {
+            return null;
+        }
+
         if ($this->validateSecurityHashMatch($this->httpRequest, $contentAsStdObj) === false) {
             return null;
         }