Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to foundry v1 (stable) #2052

Merged
merged 6 commits into from
Feb 21, 2025
Merged

switch to foundry v1 (stable) #2052

merged 6 commits into from
Feb 21, 2025

Conversation

d10r
Copy link
Collaborator

@d10r d10r commented Feb 18, 2025

No description provided.

Copy link

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.03%. Comparing base (b86ec54) to head (6a8662b).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2052      +/-   ##
==========================================
+ Coverage   88.09%   90.03%   +1.94%     
==========================================
  Files         109      109              
  Lines        6903     6904       +1     
  Branches      999     1001       +2     
==========================================
+ Hits         6081     6216     +135     
+ Misses        820      686     -134     
  Partials        2        2              
Flag Coverage Δ
ethereum-contracts 97.93% <ø> (+3.90%) ⬆️
sdk-core 90.03% <ø> (+1.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -3,6 +3,8 @@ root = '../../../'
libs = ['lib']
src = 'packages/automation-contracts/autowrap'
solc_version = "0.8.23"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we also mark evm_version explicitly?

@@ -3,6 +3,8 @@ root = '../../../'
libs = ['lib']
src = 'packages/automation-contracts/scheduler'
solc_version = "0.8.23"
optimizer = true
optimizer_runs = 200
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

@hellwolf hellwolf marked this pull request as ready for review February 21, 2025 19:35
@hellwolf hellwolf merged commit b30b7be into dev Feb 21, 2025
27 checks passed
@hellwolf hellwolf deleted the foundry_v1 branch February 21, 2025 19:36
Copy link

XKCD Comic Relif

Link: https://xkcd.com/2052
https://xkcd.com/2052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants