Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to Poetry v2.0 #266

Merged
merged 7 commits into from
Jan 20, 2025
Merged

feat: upgrade to Poetry v2.0 #266

merged 7 commits into from
Jan 20, 2025

Conversation

lsorber
Copy link
Member

@lsorber lsorber commented Jan 16, 2025

Changes:

  • Upgrade to Poetry v2.0
  • Upgrade antidote to v1.9.7
  • Small improvement to the Ruff config
  • Remove codecov

@lsorber lsorber requested a review from sinopeus January 16, 2025 13:30
@lsorber lsorber self-assigned this Jan 16, 2025
Copy link
Collaborator

@sinopeus sinopeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two comments, will still test it on my end as well 🙂

If you use PEP621, there is no longer a `main` dependency group with that name, which breaks `poetry install --only main`. The alternative is to actively exclude the test and dev dependency groups, which is not optimal but fixes things.

This flow broke on my machine but not in CI. It's worth investigating why that is the case.
@sinopeus
Copy link
Collaborator

Everything looks good except one thing that didn't work on my end. I took the liberty of fixing it in this commit. Let me know whether you think that makes sense, I find it strange that it worked in CI but not on my machine.

@lsorber lsorber merged commit bf11879 into main Jan 20, 2025
8 checks passed
@lsorber lsorber deleted the ls-poetry-v2 branch January 20, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants