[SuperEditor][SuperReader][Android] Fix scrolling with an ancestor Scrollable (Resolves #1535) #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -581,6 +581,60 @@ void main() { | |||
| expect(caretOffset.dy, greaterThanOrEqualTo(screenSizeWithKeyboard.height - trailingBoundary)); | |||
| }); | |||
|
|
|||
| testWidgetsOnMobile('scrolls when dragging without attaching to IME', (tester) async { | |||
There was a problem hiding this comment.
This test name should probably read "scrolling doesn't cause the keyboard to open"
angelosilvestre
added a commit
to angelosilvestre/super_editor
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SuperEditor][SuperReader][Android] Fix scrolling with an ancestor Scrollable. Resolves #1535.
When the editor or reader is inside a
CustomScrollview, trying to drag is opening the software keyboard and changing the selection.The root cause is the long press to select handling. When the user taps down we start a timer to track a long press. Dragging after the tap down starts a pan gesture and we cancel the timer. However, if we have an ancestor
Scrollable, dragging starts a pan gesture on theScrollable, not in the editor/reader. Because of that, the timer still fires after the timeout.This PR adds a guard clause to avoid doing a long press if we are scrolling.