[Super Editor] - Fix KeyboardScaffoldSafeArea so that when there's only a single scope, that scope is used instead of MediaQuery (Resolves #2502) #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly a single scope, that scope is used instead of MediaQuery (Resolves #2502)
|
@angelosilvestre I'm gonna merge and cut a new release to fix this bug in ClickUp. Feel free to comment after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Super Editor] - Fix KeyboardScaffoldSafeArea so that when there's only a single scope, that scope is used instead of MediaQuery (Resolves #2502)
The
KeyboardScaffoldSafeAreaandKeyboardScaffoldSafeAreaScopetalk to each other in the widget tree so that they respect their ancestors. However, I focused so much on that intercommunication that I screwed up the case of a single safe area scope. This PR fixes that issue by applying the safe area insets from the singular safe area scope, when there's no ancestor.