[SuperEditor][SuperTextField] Improve RTL support (Resolves #2472) #2518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SuperEditor][SuperTextField] Improve RTL support. Resolves #2472
We have some issues in RTL support:
For
SuperEditor
, we have code to infer the text direction from the text itself, but we weren't passing the text direction down theTextComponent
, and we were also not passing it toLayoutAwareRichText
. As the result, the caret position is computed as if we are in LTR.For
SuperTextField
, we weren't inferring the text direction from the text.This PR makes the following changes:
LayoutAwareRichText
.SuperTextField
'stextAlign
nullable, to choose the alignment based on the text direction, if the app doesn't enforce a text alignment.