[SuperEditor][web] Fix double tap closing the IME connection on Safari/Firefox (Resolves #2513) #2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i/Firefox (Resolves #2513)
matthew-carroll
deleted the
2513_fix-double-tap-clearing-selection-safari
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SuperEditor][web] Fix double tap closing the IME connection on Safari/Firefox. Resolves #2513
On Safari/Firefox, double tapping to select a word and then pressing backspace, delete, or any letter does nothing and stops the editor from responding to key presses.
I noticed this only happens when the selection is expanded by double tapping. When expanding by dragging, or pressing SHIFT + ARROW key it works correctly. What's happening is that we are closing the IME connection and then immediately reopening it, and it doesn't seem to work correctly on Safari/Firefox. This is the sequence of events:
SuperEditorImePolicies.closeKeyboardOnSelectionLostistrue, we close the IME connectionThis PR modifies the double tap handler to only clear the existing selection if we weren't able to place a new selection. I tried with both Safari and Firefox and this seems to fix the issue.