chore: add version flag test #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin404
reviewed
May 22, 2024
pkg/version/flag.go
Outdated
| @@ -83,14 +96,21 @@ func AddFlags(fs *flag.FlagSet) { | |||
| fs.AddFlag(flag.Lookup(versionFlagName)) | |||
| } | |||
|
|
|||
| // variables for unit testing PrintAndExitIfRequested | |||
| var ( | |||
| appName = "onex-apiserver" | |||
There was a problem hiding this comment.
这里不能写appName=“onex-apiserver”，这么一写，pkg/version包就跟onex项目的onex-apiserver耦合了。变成了一个非完全独立的Go包，version包也不适合放在pkg/目录下了。
pkg/version/flag.go
Outdated
| @@ -39,6 +42,16 @@ func (v *versionValue) Set(s string) error { | |||
| *v = VersionRaw | |||
| return nil | |||
| } | |||
|
|
|||
| if strings.HasPrefix(s, "v") { | |||
| err := version.SetDynamicVersion(s) | |||
There was a problem hiding this comment.
github.com/superproj/onex/pkg/version 有SetDynamicVersion，可以直接引用
There was a problem hiding this comment.
has been modified, thanks for review the code again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind chore
What this PR does / why we need it:
fix version flag test