Enable dynamic aiida-core version input for GitHub Actions

This update allows the aiida-core version to be specified at the workflow level and dynamically passed to the integration-tests action.
superstar54 · Mar 21, 2024 · 0b2c47b · 0b2c47b
1 parent c70508e
commit 0b2c47b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/.github/actions/integration-tests/action.yml b/.github/actions/integration-tests/action.yml
@@ -11,14 +11,14 @@ inputs:
         description: GitHub Actions Runner image
         required: true
         type: string
+    aiidaCoreVersion: # Define aiida-core-version as an input
+        description: aiida-core version
+        required: true
+        type: string
 
 runs:
     using: composite
 
-    strategy:
-        matrix:
-            aiida-core-version: [2.3, 2.4.3]          # test on the latest and the oldest supported version
-
     steps:
         - name: Set jupyter token env
           run: echo "JUPYTER_TOKEN=$(openssl rand -hex 32)" >> $GITHUB_ENV
@@ -27,7 +27,7 @@ runs:
         - name: Run pytest to test image is working
           run: pytest tests_integration/test_image.py
           env:
-              TAG: aiida-${{ matrix.aiida-core-version }}
+              TAG: aiida-${{ inputs.aiidaCoreVersion }}
           shell: bash
 
         # The Firefox and its engine geckodrive need do be installed manually to run
@@ -50,14 +50,14 @@ runs:
           if : ${{ inputs.architecture == 'amd64' }}
           run: pytest --driver Firefox tests_integration/test_app.py
           env:
-              TAG: aiida-${{ matrix.aiida-core-version }}
+              TAG: aiida-${{ inputs.aiidaCoreVersion }}
           shell: bash
 
         - name: Run pytest for Chrome
           if : ${{ inputs.architecture == 'amd64' }}
           run: pytest --driver Chrome tests_integration/test_app.py
           env:
-              TAG: aiida-${{ matrix.aiida-core-version }}
+              TAG: aiida-${{ inputs.aiidaCoreVersion }}
           shell: bash
 
         - name: Upload screenshots as artifacts

diff --git a/.github/workflows/docker-build-test-upload.yml b/.github/workflows/docker-build-test-upload.yml
@@ -23,6 +23,9 @@ on:
 jobs:
     build-test-upload:
         runs-on: ${{ inputs.runsOn }}
+        strategy:
+            matrix:
+                aiida-core-version: [2.3, newly-baked]
         continue-on-error: true
 
         steps:
@@ -60,6 +63,7 @@ jobs:
               with:
                   architecture: ${{ inputs.architecture }}
                   runsOn: ${{ inputs.runsOn }}
+                  aiidaCoreVersion: ${{ matrix.aiida-core-version }}
 
             - name: Save image as a tar for later use 💾
               run: |